Update for matplotlib 3.9.0 #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuLogic
reviewed
Jun 15, 2024
| @@ -319,7 +319,8 @@ def test_Quiver(self): | |||
|
|
|||
| @animation_compare(baseline_images="Blocks/Surface", nframes=3) | |||
| def test_Surface(self): | |||
| if mpl._version.version_tuple < (3, 9): | |||
| mpl_version = tuple([int(x) for x in mpl._version.version.split(".")[:3]]) | |||
There was a problem hiding this comment.
You may want to use packaging.version.parse as is used in other tests instead.
There was a problem hiding this comment.
For example, this is now breaking with 3.10.0rc1:
@animation_compare(baseline_images="Blocks/Surface", nframes=3)
def test_Surface(self):
> mpl_version = tuple([int(x) for x in mpl._version.version.split(".")[:3]])
E ValueError: invalid literal for int() with base 10: '0rc1'
There was a problem hiding this comment.
Sorry for not fixing earlier:
844ab44
Do you want me to push the fix to fedora? Is rawhide sufficient?
There was a problem hiding this comment.
This test is the only failing one, so I suspect it will be fine:
https://copr.fedorainfracloud.org/coprs/qulogic/matplotlib-310/build/8245763/
But a build in Rawhide would be handy to check, or I could build the patch in this COPR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #18