Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bowtie run example for smoke test #1326

Closed
wants to merge 7 commits into from
Closed

Bowtie run example for smoke test #1326

wants to merge 7 commits into from

Conversation

adwait-godbole
Copy link
Contributor

@adwait-godbole adwait-godbole commented Jun 23, 2024

resolves #1319

@Julian is this fine ?


📚 Documentation preview 📚: https://bowtie-json-schema--1326.org.readthedocs.build/en/1326/

@@ -215,6 +216,40 @@ def __rich_console__(
padding=2,
)
epilog.add_row(panel)

test = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's making you create a new test here? We want to show one of the ones that just failed, and tell the user how to run something which does that.

bowtie/_smoke.py Outdated Show resolved Hide resolved
@Julian
Copy link
Member

Julian commented Jun 24, 2024

Please also try this :) -- running something which triggers it, via e.g. bowtie smoke -i direct:tests.fauxmplementations.miniatures:no_registry_support and then copy pasting the command it's suggesting doesn't run here because of whitespace issues.

@adwait-godbole
Copy link
Contributor Author

adwait-godbole commented Jun 24, 2024

Please also try this :) -- running something which triggers it, via e.g. bowtie smoke -i direct:tests.fauxmplementations.miniatures:no_registry_support and then copy pasting the command it's suggesting doesn't run here because of whitespace issues.

sorry but I am unable to fix this :(. Since its a multiline JSON I tried various ways but didn't work.

@Julian
Copy link
Member

Julian commented Jun 24, 2024

No worries. I don't have time to look right now there are a few other things that need doing but we can come back to this then when we have something which works.

@Julian Julian closed this Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show what command will reproduce a $ref failure in bowtie smoke
2 participants