-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Override toString() in Info classes to encode them back to JSON #52
Labels
enhancement
Added to issues that describes enhancements
Milestone
Comments
Appears to have been added by PR#461 |
richiehowelll
added a commit
to richiehowelll/box-java-sdk
that referenced
this issue
Aug 12, 2020
Introduced a JsonObject field that will preserve the current JSON object. This field is set in BoxJSONObject.update. BoxJSONObject.toString is overriden to convert this object to a string literal. Closes box#52.
richiehowelll
added a commit
to richiehowelll/box-java-sdk
that referenced
this issue
Aug 12, 2020
Following the Box coding conventions and using this keyword when referencing field. Closes box#52.
I do not think that toString method should return Json object representation with all the changes. This method is used mostly for debugging/logging so it should be fast . What is required here does not look like it fits into toString specification. All Info objects have to methods:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Calling
toString()
on an Info object should return the full JSON representation of the object, including any changes made locally.This feature makes it easier for applications to cache and store data returned from the API.
The text was updated successfully, but these errors were encountered: