-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more status codes Closes #2 #15
Conversation
"I'M A TEAPOT": "418", | ||
"UPGRADE REQUIRED": "426", | ||
"**SERVER ERROR**": "5xx", | ||
"INTERNAL SERVER ERROR": "500", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Notice that this no longer has the underscores as previously. Is that going to be a problem?
Codecov Report
@@ Coverage Diff @@
## master #15 +/- ##
=======================================
Coverage 93.44% 93.44%
=======================================
Files 16 16
Lines 229 229
Branches 43 43
=======================================
Hits 214 214
Misses 15 15 |
Wow thanks @dawsbot , That dropdown list is abit epic and long! Some crazy status codes in there Also, each status code has to work with express as the get mapped in the server code. So things like |
Good question, I'm not sure if the XX's will work with express. I actually don't undestand the docker build setup in this project for local dev, so testing everything takes a very long time. Perhaps you can provide more info for how to run everything locally? On React changes, I had to kill docker and restart everything 😂 |
@dawsbot Can you use e.g
|
@mrjasongorman feel free to take my progress and run with it, I won't get time for this for 1 week or more. You've now got write access on my fork |
@mrjasongorman fancy helping out on this one? |
Hey @dawsbot We have some more status codes coming in 1.1.0 (released very soon), I'm not 💯 about the UI on this one, so I'm going to leave it out for now. Feel free to pick it back up if you get the time or chance too. |
What: Add more http status codes
Why: Closes #2
How: Found a friendly json list from here, ran a quick script, and inserted them into the codebase. After testing both unit testing and visually, I think it's ready for feedback!
Checklist: