Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ncurses glitch on startup #96

Open
steils opened this issue Jan 3, 2021 · 4 comments
Open

Ncurses glitch on startup #96

steils opened this issue Jan 3, 2021 · 4 comments

Comments

@steils
Copy link
Contributor

steils commented Jan 3, 2021

If I start vimpc like urxvt -e vimpc or st -e vimpc (it's useful if I want to use a hotkey to start vimpc) I get something like this every time:

screenshot-2021-01-03_164711

If I start terminal first, and then start vimpc, everything is ok.
The WM is i3 if it matters, and the default layout is "tabbed" (new windows start maximized).

I'm not very familiar with ncurses, but I've made a (crude) fix which works fine for me:

diff --git a/src/vimpc.cpp b/src/vimpc.cpp
index 8754281..829e8c0 100644
--- a/src/vimpc.cpp
+++ b/src/vimpc.cpp
@@ -239,6 +239,8 @@ void Vimpc::Run(std::string hostname, uint16_t port)
          if (((input != ERR) || (Resize == true)) || (requireRepaint_ == true))
          {
             QueueMutex.unlock();
+            endwin();
+            refresh();
             Repaint();
          }
          else

WDYT?

@steils
Copy link
Contributor Author

steils commented Jan 3, 2021

P.S. I don't have such glitches with other ncurses programs. mutt, irssi, htop, mc work fine if I start them like that.

@steils
Copy link
Contributor Author

steils commented Jan 28, 2021

@boysetsfrog @connermcd hi?

@steils
Copy link
Contributor Author

steils commented Mar 2, 2021

$ ping @connermcd @boysetsfrog

@connermcd
Copy link
Collaborator

I'm not able to recreate this on my machine with urxvt -e vimpc. Your local system or urxvt settings may be involved. Are you still having the issue? Are you in the playlist window (I can't tell from screenshot)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants