From b59fc07df979a5656f4701426de09b37f4938853 Mon Sep 17 00:00:00 2001
From: bp2008 <bp2008@users.noreply.github.com>
Date: Mon, 12 Feb 2024 08:11:23 -0700
Subject: [PATCH] Version 268: * Fixed a bug in the implementation of the
 `OverrideDefaultSetting` method's `IncludeInOptionsWindow` argument (used in
 `ui3-local-overrides.js` files).   * This argument's value is now persisted
 when you have UI3 generate a new local overrides file (as was originally
 intended).   * Calling `OverrideDefaultSetting` with `IncludeInOptionsWindow`
 set to false no longer is irreversible; you can call it again set to true to
 re-show a setting that was hidden by an earlier call.

---
 ui3.htm    | 2 +-
 ui3/ui3.js | 7 +++----
 2 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/ui3.htm b/ui3.htm
index 7e1ef5b..8980f49 100644
--- a/ui3.htm
+++ b/ui3.htm
@@ -88,7 +88,7 @@
 		};
 	</script>
 	<script type="text/javascript">
-		var ui_version = "267";
+		var ui_version = "268";
 		var bi_version = "%%VERSION%%";
 		var appPath_raw = "%%VIRTDIR%%";
 		var local_bi_session = "%%SESSION%%";
diff --git a/ui3/ui3.js b/ui3/ui3.js
index 39c6d94..8bff695 100644
--- a/ui3/ui3.js
+++ b/ui3/ui3.js
@@ -3145,8 +3145,7 @@ function OverrideDefaultSetting(key, value, IncludeInOptionsWindow, AlwaysReload
 			defaultSettings[i].value = value;
 			defaultSettings[i].AlwaysReload = AlwaysReload;
 			defaultSettings[i].Generation = Generation;
-			if (!IncludeInOptionsWindow)
-				defaultSettings[i].label = null;
+			defaultSettings[i].IncludeInOptionsWindow = IncludeInOptionsWindow;
 			break;
 		}
 }
@@ -31871,7 +31870,7 @@ function UISettingsPanel()
 		for (var i = 0; i < defaultSettings.length; i++)
 		{
 			var s = defaultSettings[i];
-			if (s.label)
+			if (s.label && (typeof s.IncludeInOptionsWindow == "undefined" || s.IncludeInOptionsWindow))
 			{
 				if (typeof s.category == "undefined")
 					s.category = "Uncategorized";
@@ -31937,7 +31936,7 @@ function UISettingsPanel()
 		for (var i = 0; i < defaultSettings.length; i++)
 		{
 			var s = defaultSettings[i];
-			var isDisplayable = (s.label || (s.comment && s.inputType === "comment")) && s.category === category;
+			var isDisplayable = (s.label || (s.comment && s.inputType === "comment")) && s.category === category && (typeof s.IncludeInOptionsWindow == "undefined" || s.IncludeInOptionsWindow);
 			if (isDisplayable && (typeof s.preconditionFunc !== "function" || s.preconditionFunc()) && processFilter(s))
 			{
 				var $row = $('<div class="uiSettingsRow withDefaultBtn"></div>');