Handle Mac address 'none' (sonic-net#2593)

In some rare cases, kernel neighbor add notifications are received with Mac string as 'none'. Fixing this to prevent crash.
bradh352 · Nov 6, 2023 · 178166e · 178166e
1 parent 8dfd4af
commit 178166e
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/neighsyncd/neighsync.cpp b/neighsyncd/neighsync.cpp
@@ -143,6 +143,12 @@ void NeighSync::onMsg(int nlmsg_type, struct nl_object *obj)
         nl_addr2str(rtnl_neigh_get_lladdr(neigh), macStr, MAX_ADDR_SIZE);
     }
 
+    if (!delete_key && !strncmp(macStr, "none", MAX_ADDR_SIZE))
+    {
+        SWSS_LOG_NOTICE("Mac address is 'none' for ADD op, ignoring for %s", ipStr);
+        return;
+    }
+
     /* Ignore neighbor entries with Broadcast Mac - Trigger for directed broadcast */
     if (!delete_key && (MacAddress(macStr) == MacAddress("ff:ff:ff:ff:ff:ff")))
     {