Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the links to Nativescript Core Packages to work with NS-8 #54

Open
ovaltechnologiesinc opened this issue Oct 31, 2021 · 0 comments

Comments

@ovaltechnologiesinc
Copy link

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch [email protected] for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/nativescript-advanced-webview/advanced-webview.android.js b/node_modules/nativescript-advanced-webview/advanced-webview.android.js
index b084670..38df641 100644
--- a/node_modules/nativescript-advanced-webview/advanced-webview.android.js
+++ b/node_modules/nativescript-advanced-webview/advanced-webview.android.js
@@ -1,8 +1,13 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-var app = require("tns-core-modules/application");
-var color_1 = require("tns-core-modules/color");
-var utils_1 = require("tns-core-modules/utils/utils");
+
+const { Application, Color, Utils } = require("@nativescript/core")
+
+const app = Application
+const color_1 = Color
+const utils_1 = Utils
+
+
 var REQUEST_CODE = 1868;
 function init() {
     co.fitcom.fancywebview.AdvancedWebView.AdvancedWebViewStatics.init(utils_1.ad.getApplicationContext(), true);

This issue body was partially generated by patch-package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant