Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Has this been tested with Winston 3.0.0? #14

Open
jeffmcaffer opened this issue Jul 15, 2018 · 3 comments
Open

Has this been tested with Winston 3.0.0? #14

jeffmcaffer opened this issue Jul 15, 2018 · 3 comments

Comments

@jeffmcaffer
Copy link
Contributor

The Winston folks released 3.0 about a month ago (mid June) and there are apparently a number of breaking changes. The current dependency is on ^2.3.0 so we are safe from the breakage but I'm wondering if there are any plans to move to 3.0?

@willmorgan
Copy link
Collaborator

Winston 3 looks like a good upgrade, but no, it hasn't been tested with 3.0 yet.

No short term plans to do this at the moment, but this is something I'd be open to contributions for / be willing to do myself.

@willmorgan
Copy link
Collaborator

@jeffmcaffer Following up on this. The project I'm principally using this on seems to be reporting with the wrong severity level with a certain configuration (AI autoCollectConsole disabled), but if you look closely then it seems that Winston 2.0 publishes to diagnostic-channel, which AI auto collects.

I do wonder if Winston 3.0 still auto-publishes, and if so, then if using this module is still needed.

@willmorgan
Copy link
Collaborator

@jeffmcaffer See willmorgan#2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants