Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cordon off IO operations #35

Open
1 of 2 tasks
ebrahimebrahim opened this issue Apr 25, 2024 · 0 comments · May be fixed by #54
Open
1 of 2 tasks

Cordon off IO operations #35

ebrahimebrahim opened this issue Apr 25, 2024 · 0 comments · May be fixed by #54
Assignees

Comments

@ebrahimebrahim
Copy link
Member

ebrahimebrahim commented Apr 25, 2024

We should try to follow the principle of keeping IO separate and cordon off the IO aspects of this package into its own module.

There could be an abcdmicro.io module that contains all the IO stuff -- specifics about how we read and write data to disk, governing which file formats we can handle.

We can discuss more below about how to approach this.


@ebrahimebrahim ebrahimebrahim linked a pull request Jul 31, 2024 that will close this issue
8 tasks
@ebrahimebrahim ebrahimebrahim moved this to In Progress in ABCD Y2Q1 Aug 12, 2024
ebrahimebrahim added a commit that referenced this issue Aug 17, 2024
I had factored out the repetitive pattern that connected
on-disk and in-memory implementations, but mypy was very
difficult to please. Now I have removed the decorator
and allowed the repetition.
This makes it easier to read and maintain so meh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
2 participants