Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW]: No plots in plot_jax.py #68

Closed
pitmonticone opened this issue Oct 17, 2024 · 1 comment
Closed

[REVIEW]: No plots in plot_jax.py #68

pitmonticone opened this issue Oct 17, 2024 · 1 comment

Comments

@pitmonticone
Copy link
Contributor

Dear authors,

The name of the example script examples/miscellaneous/plot_jax.py does not perform any plotting. It may be helpful to either rename the script to better reflect its functionality or modify the script to include plotting if that was the intended purpose.

REVIEW ISSUE: openjournals/joss-reviews#7360
@EtienneCmb
Copy link
Collaborator

Indeed, we used plot_jax for the same reason as #64. We renamed the file for examples/miscellaneous/plot_jax.py.

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@EtienneCmb @pitmonticone