Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Real life accuracy & bug in parse_match_data #2

Open
m-kloeckner opened this issue Nov 6, 2019 · 1 comment
Open

Real life accuracy & bug in parse_match_data #2

m-kloeckner opened this issue Nov 6, 2019 · 1 comment

Comments

@m-kloeckner
Copy link

This is a very interesting project! Thank you very much for sharing this. Can you provide some experience on the real life accuracy of your model? Did you work on this any further?

Why am I asking: The 99% accuracy in training and validation actually feels a bit odd. When reviewing the code I found a bug in line 114 of prediction.py. It seems that the match data is constructed of multiple copies of year 2010's match data. This would result in identical data for training an evaluation - which would in turn explain the high accuracy.

See

content = open(match_data_directory + "/matchdata" + str(2010) + ".txt", "r").read()

@brakid
Copy link
Owner

brakid commented Nov 6, 2019

Good catch, indeed. This is a mistake that indeed can be responsible for the super-high accuracy in training and validation.

I did not test the model further (unfortunately), but would be happy to hear more if you are trying it out in more detail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants