Wrong usage of @defer.reject()

[devgru]

Here we call @defer.reject() with two arguments:
https://github.com/bramski/angular-indexedDB/blob/master/src/angular-indexed-db.coffee#L161-L171

The second argument of reject method is ignored, so actual error is lost and we just get "Transaction Error" string in promise.

[bramski]

What form of rejection would be preferred?

[devgru]

IMHO actual error is enough.

Maybe it's a good idea to reject with object, like this:

@defer.reject({title: "Transaction Aborted", error: error})
@defer.reject({title: "Transaction Error", error: error})

[devgru]

@bramski will it be useful if I write PR with this change?

[bramski]

Yes for sure.
On Jul 11, 2016 3:13 AM, "Dmitriy Semyushkin" [email protected]
wrote:

@bramski https://github.com/bramski will it be useful if I write PR
with this change?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#65 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAZvlYKjxhqpR-PjdN3UUA3lF8317EIuks5qUhdNgaJpZM4I-4Sj
.

[devgru]

Here you are:
#66

[bramski]

Merged.