Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calc-size support for Edge wrong #2

Closed
bramus opened this issue Sep 6, 2024 · 2 comments
Closed

calc-size support for Edge wrong #2

bramus opened this issue Sep 6, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@bramus
Copy link
Owner

bramus commented Sep 6, 2024

It’s green but should be all red – just like https://caniuse.com/#feat=mdn-css_types_calc-size

image
@bramus bramus added the bug Something isn't working label Sep 6, 2024
@bramus
Copy link
Owner Author

bramus commented Sep 13, 2024

Found the problem: the feature is marked as added in Edge 129 but that release is not included in the caniuse.agents.edge.version_list because that version – at the time of writing – has not been released (as stable) yet.

Trying to fall back to the versions declared in BCD instead – which does included Edge 129 – would be possible, but the problem is that it’s an object and the order of the releases is therefore not guaranteed when looping over them.

While I could try and fall back to extracting the release from BCD whose status is marked as "beta" (and the one after that "nightly") and manually push them onto .agents.edge.version_list I won’t because (1) caniuse.com itself doesn’t do that and (2) it’s a caniuse data problem.

Instead, the fix is to skip the coloring when the version_added value doesn’t appear in the version_list.

@bramus bramus closed this as completed in 1d7680e Sep 13, 2024
@bramus
Copy link
Owner Author

bramus commented Sep 13, 2024

As a follow-up, I filed Fyrd/caniuse#7153 to fix the data issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant