-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fetches project id for every issue creation #5
Comments
It would definitely help if an An option might be to add another set of fields to To avoid having to migrate old errbit installations, a mechanism like
As a new tracker instance is created every time, it might also be a good idea to have an explicit |
These sounds like some good ideas. I'd be very hesitant to break backwards compatibility with the issue tracker interface because that would mean new versions of every plugin. But I think this could be done without having to go down that road. |
According to GitLab documentation (http://doc.gitlab.com/ce/api/projects.html#get-single-project)
So there is no need to fetch project id, we can pass project name with namespace to issue create method. |
Changing the However, I think the main problem is that the issue tracker is valided every time a new issue is created. This means, that we either have to remove all validations performed in |
Project_ids presumably don't change very often or ever, so it's not efficient to fetch the project_id every time we create an issue. But that's what we're doing. We should stop doing this and set the project_id once instead.
In order to not need a migration, we should make it set the project_id when saving the issue tracker (to make future errbits more efficient), and also fetch the project_id live (to keep already configured errbits working).
The text was updated successfully, but these errors were encountered: