From 1374b77409e3c42151428b5237c1643bcea7302f Mon Sep 17 00:00:00 2001 From: Brendan Slabe Date: Thu, 18 Jul 2024 19:23:24 +0200 Subject: [PATCH] Make image names optional in Jetstream Maxtext module (#744) first commit --- modules/jetstream-maxtext-deployment/variables.tf | 4 ++-- .../single-host-inference/terraform/sample-terraform.tfvars | 3 --- .../maxtext/single-host-inference/terraform/variables.tf | 4 ++-- 3 files changed, 4 insertions(+), 7 deletions(-) diff --git a/modules/jetstream-maxtext-deployment/variables.tf b/modules/jetstream-maxtext-deployment/variables.tf index 76c073282..c3998a6a9 100644 --- a/modules/jetstream-maxtext-deployment/variables.tf +++ b/modules/jetstream-maxtext-deployment/variables.tf @@ -26,8 +26,8 @@ variable "project_id" { variable "maxengine_deployment_settings" { type = object({ - maxengine_server_image = string - jetstream_http_server_image = string + maxengine_server_image = optional(string, "us-docker.pkg.dev/cloud-tpu-images/inference/maxengine-server:v0.2.2") + jetstream_http_server_image = optional(string, "us-docker.pkg.dev/cloud-tpu-images/inference/jetstream-http:v0.2.2") model_name = string // Name of your LLM (for example: "gemma-7b") parameters_path = string // Path to the paramters for your model diff --git a/tutorials-and-examples/inference-servers/jetstream/maxtext/single-host-inference/terraform/sample-terraform.tfvars b/tutorials-and-examples/inference-servers/jetstream/maxtext/single-host-inference/terraform/sample-terraform.tfvars index d9095f9c9..3e4a64558 100644 --- a/tutorials-and-examples/inference-servers/jetstream/maxtext/single-host-inference/terraform/sample-terraform.tfvars +++ b/tutorials-and-examples/inference-servers/jetstream/maxtext/single-host-inference/terraform/sample-terraform.tfvars @@ -1,7 +1,4 @@ maxengine_deployment_settings = { - maxengine_server_image = "us-docker.pkg.dev/cloud-tpu-images/inference/maxengine-server:v0.2.2" - jetstream_http_server_image = "us-docker.pkg.dev/cloud-tpu-images/inference/jetstream-http:v0.2.2" - metrics_port = 9100 metrics_scrape_interval = 10 accelerator_selectors = { diff --git a/tutorials-and-examples/inference-servers/jetstream/maxtext/single-host-inference/terraform/variables.tf b/tutorials-and-examples/inference-servers/jetstream/maxtext/single-host-inference/terraform/variables.tf index bac9114fe..368740df7 100644 --- a/tutorials-and-examples/inference-servers/jetstream/maxtext/single-host-inference/terraform/variables.tf +++ b/tutorials-and-examples/inference-servers/jetstream/maxtext/single-host-inference/terraform/variables.tf @@ -51,8 +51,8 @@ variable "cluster_name" { variable "maxengine_deployment_settings" { type = object({ - maxengine_server_image = string - jetstream_http_server_image = string + maxengine_server_image = optional(string) + jetstream_http_server_image = optional(string) model_name = string // Name of your LLM (for example: "gemma-7b") parameters_path = string // Path to the parameters for your model