Skip to content
This repository has been archived by the owner on Feb 6, 2023. It is now read-only.

High block counts from shields #1

Open
lukemulks opened this issue Jan 25, 2019 · 2 comments
Open

High block counts from shields #1

lukemulks opened this issue Jan 25, 2019 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@lukemulks
Copy link
Collaborator

Brave shields are blocking 23 requests on batcommunity.org, without us running ads and tracking (aside from piwik).

The vast majority of these are twitter related. Going to open an issue for that in brave-browser, but want to capture the issue here for reference.

We should aim to have 0 block counts on this site before launch.
@Miyayes

https://analytics.brave.com/piwik.js
https://syndication.twitter.com/i/jot/syndication?l=%7B%22_category_%22%3A%22syndicated_impression%22%2C%22triggered_on%22%3A1548456630704%2C%22dnt%22%3Afalse%2C%22event_namespace%22%3A%7B%22client%22%3A%22tfw%22%2C%22page%22%3A%22timeline%22%2C%22action%22%3A%22impression%22%7D%7D
https://syndication.twitter.com/i/jot?l=%7B%22widget_origin%22%3A%22https%3A%2F%2Fbatcommunity.org%2Findex.html%22%2C%22widget_frame%22%3Afalse%2C%22widget_data_source%22%3A%22profile%3ABAT_Community%22%2C%22query%22%3Anull%2C%22profile_id%22%3Anull%2C%22_category_%22%3A%22tfw_client_event%22%2C%22triggered_on%22%3A1548456638637%2C%22dnt%22%3Afalse%2C%22client_version%22%3A%222016731%3A1547706399649%22%2C%22format_version%22%3A%222016731%3A1547706399649%22%2C%22event_namespace%22%3A%7B%22client%22%3A%22tfw%22%2C%22page%22%3A%22timeline%22%2C%22element%22%3A%22notice%22%2C%22section%22%3A%22header%22%2C%22action%22%3A%22seen%22%7D%7D&notice_seen=true
https://syndication.twitter.com/i/jot
https://abs.twimg.com/emoji/v2/72x72/1f4c4.png
https://abs.twimg.com/emoji/v2/72x72/1f4a5.png
https://abs.twimg.com/emoji/v2/72x72/1f981.png
https://abs.twimg.com/emoji/v2/72x72/1f680.png
https://abs.twimg.com/emoji/v2/72x72/2728.png
https://abs.twimg.com/emoji/v2/72x72/1f60d.png
https://abs.twimg.com/emoji/v2/72x72/1f4cd.png
https://abs.twimg.com/emoji/v2/72x72/25b6.png
https://abs.twimg.com/emoji/v2/72x72/1f4fd.png
https://abs.twimg.com/emoji/v2/72x72/1f399.png
https://abs.twimg.com/emoji/v2/72x72/1f375.png
https://abs.twimg.com/emoji/v2/72x72/1f525.png
https://abs.twimg.com/emoji/v2/72x72/1f409.png
https://abs.twimg.com/emoji/v2/72x72/1f455.png
https://abs.twimg.com/emoji/v2/72x72/1f4ab.png
https://abs.twimg.com/emoji/v2/72x72/1f440.png
https://abs.twimg.com/emoji/v2/72x72/1f5a5.png
https://abs.twimg.com/emoji/v2/72x72/1f3ac.png
https://ton.twimg.com/tfw/css/syndication_bundle_v1_73385286cca9d2256f6bf3993470820d4827b058.css

@Miyayes
Copy link
Collaborator

Miyayes commented Jan 26, 2019

It is certainly strange that every instance of an emoji in the Twitter feed (such as https://abs.twimg.com/emoji/v2/72x72/1f5a5.png) is being treated as an ad/tracker.

@Miyayes Miyayes added the release-blocking blocking relese label Jan 29, 2019
@Miyayes Miyayes added help wanted Extra attention is needed and removed release-blocking blocking relese labels Feb 13, 2019
@fmarier
Copy link
Member

fmarier commented Feb 14, 2019

These blocked abs.twimg.com requests are there because twimg.com is present on our copy of the Disconnect list but and not whitelisted (unlike pbs.twimg.com).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants