Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add highlight to Shields button during onboarding #27490

Closed
rebron opened this issue Dec 21, 2022 · 3 comments · Fixed by brave/brave-core#15198
Closed

Add highlight to Shields button during onboarding #27490

rebron opened this issue Dec 21, 2022 · 3 comments · Fixed by brave/brave-core#15198
Assignees
Labels
onboarding Front-end related to helping a new user learn about features within the browser. OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include

Comments

@rebron
Copy link
Collaborator

rebron commented Dec 21, 2022

Description

After a user goes through brave://welcome and when visiting their first web site with greater than 0 ads and trackers blocked, we will highlight the shields icon in the url bar.

Expected result:

196289117-62370813-42ec-4573-aedc-86b23c036aa0

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? n/a
  • Can you reproduce this issue with the nightly channel? n/a

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

Related issue:
#26378
#4247

@rebron rebron added OS/Desktop onboarding Front-end related to helping a new user learn about features within the browser. labels Dec 21, 2022
@rebron rebron added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes labels Dec 21, 2022
@rebron rebron assigned simonhong and unassigned nullhook Sep 15, 2023
@brave-builds brave-builds added this to the 1.63.x - Nightly milestone Dec 7, 2023
@MadhaviSeelam
Copy link

MadhaviSeelam commented Dec 14, 2023

Verification PASSED using

Brave | 1.63.41 Chromium: 120.0.6099.115 (Official Build) nightly (64-bit)
-- | --
Revision | c56c5ba04606284792201770bb6cb52d1ef367b6
OS | Windows 11 Version 22H2 (Build 22621.2861)

Case 1: visit to first web site with greater than 0 ads and trackers - PASSED

  1. Installed 1.63.41
  2. launched Brave
  3. clicked Set Brave as default browser>>Skip >>Finish
  4. visited bbc.com
  5. clicked Shields button
  6. closed and relaunched Brave
  7. visit another website in a new tab (eg. nytimes.com)

Confirmed Shields button in the URL bar is highlighted with pulse animation along with the bubble

Confirmed Shields onboarding is dismissed

Confirmed when Brave closed and relaunched Shields onboarding is dismissed

Confirmed Shields onboarding is not shown for another website in a new tab

2023-12-14_13h25_15.mp4

Case 2: visit to first web site with 0 ads and trackers - PASSED

  1. new profile
  2. launched Brave
  3. clicked Set Brave as default browser>>Skip >>Finish
  4. visited brave.com
  5. visited a site in a new tab with ads and trackers (eg. nytimes.com)

Confirmed Shields onboarding is not shown on a first website with 0 ads and trackers(brave.com)

Confirmed Shields onboarding is shown on a second tab with ads and trackers

step 3a step 3b step 3c step 4 step 5
image image image image image

Case 3: Pulse animation should not be shown with --disable-gpu - FAILED

  1. Installed 1.63.41
  2. launched Brave with --disable-gpu
  3. visited bbc.com

Actual results: Pulse animation shown on the Shields onboarding

2023-12-14_13h35_27.mp4

Dark theme:

image

Encountered #34802

@stephendonner
Copy link

stephendonner commented Jan 31, 2024

Verification PASSED using

Brave | 1.63.138 Chromium: 121.0.6167.85 (Official Build) beta (x86_64)
-- | --
Revision | 742a3bdf71b710125a1c1dd8e89981b9009a87bc
OS | macOS Version 11.7.10 (Build 20G1427)

Case 1: visit to first website with greater than 0 ads and trackers - PASSED

Multi-source trackers (msn.com)

Screen Shot 2024-01-30 at 5 50 59 PM

Single-source trackers (tmz.com)

Screen Shot 2024-01-30 at 5 56 55 PM

Case 2: visit to first website with 0 ads and trackers - PASSED

search.brave.com yahoo.com
Screen Shot 2024-01-30 at 5 23 50 PM Screen Shot 2024-01-30 at 5 24 42 PM

Case 3: pulse animation should not be shown with --disable-gpu - FAILED

shields-animation

Encountered

@stephendonner stephendonner added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jan 31, 2024
@MadhaviSeelam
Copy link

MadhaviSeelam commented Feb 5, 2024

Verification PASSED using

Brave	1.63.142 Chromium: 121.0.6167.139 (Official Build) beta (64-bit) 
Revision	7f6a671325da3f7f1ba2680c7a2115f895b4ff6b
OS	Linux

Case 1: visit to first web site with greater than 0 ads and trackers - PASSED

  1. Installed 1.63.142
  2. launched Brave
  3. clicked Set Brave as default browser>>Skip >>Finish
  4. visited usatoday.com
  5. clicked Shields button
  6. closed and relaunched Brave
  7. visit another website in a new tab (eg. nytimes.com)
  • Confirmed Shields button in the URL bar is highlighted with pulse animation along with the bubble
  • Confirmed Shields onboarding is dismissed when clicked
  • Confirmed when Brave closed and relaunched Shields onboarding is dismissed
  • Confirmed Shields onboarding is not shown for another website in a new tab**
example example example
Screenshot from 2024-02-05 11-00-21 Screenshot from 2024-02-05 11-01-36 Screenshot from 2024-02-05 11-23-50

Case 2: visit to first web site with 0 ads and trackers - PASSED

  1. new profile
  2. launched Brave
  3. clicked Set Brave as default browser>>Skip >>Finish
  4. visited brave.com
  5. visited a site in a new tab with ads and trackers (newsweek.com)

Confirmed Shields onboarding is not shown on a first website with 0 ads and trackers(brave.com)

Confirmed Shields onboarding is shown on a second tab with ads and trackers

example example
Screenshot from 2024-02-05 12-43-17 Screenshot from 2024-02-05 12-43-34

Case 3: Pulse animation should not be shown with --disable-gpu - FAILED

  1. new profile
  2. launched Brave with --disable-gpu
  3. visited time.com

Actual results: Pulse animation shown on the Shields onboarding

Screenshot from 2024-02-05 12-48-54

Encountered:
#34903
#34904

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
onboarding Front-end related to helping a new user learn about features within the browser. OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants