Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix detection of Google Chrome Beta/Dev as default browsers #28717

Closed
spylogsster opened this issue Feb 23, 2023 · 4 comments · Fixed by brave/brave-core#17414
Closed

Fix detection of Google Chrome Beta/Dev as default browsers #28717

spylogsster opened this issue Feb 23, 2023 · 4 comments · Fixed by brave/brave-core#17414
Assignees
@spylogsster
Labels
feature/importer l10n OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/exclude
Milestone
1.50.x - Release

Comments

@spylogsster
Copy link

spylogsster commented Feb 23, 2023 •
edited by bsclifton
Loading

Test plan

See brave/brave-core#17414

Description

Google Chrome Dev and Google Chrome Beta have traslated default browser name, need to read original google translations and compare default browser name it with them
@spylogsster spylogsster mentioned this issue Feb 23, 2023
Merged
25 tasks
@rebron rebron added feature/importer priority/P3 The next thing for us to work on. It'll ride the trains. labels Feb 24, 2023
@spylogsster spylogsster self-assigned this Feb 27, 2023
@spylogsster spylogsster mentioned this issue Feb 28, 2023
Merged
25 tasks
@bsclifton bsclifton added the l10n label Mar 1, 2023
@brave-builds brave-builds added this to the 1.50.x - Nightly milestone Mar 1, 2023
@MadhaviSeelam
Copy link

MadhaviSeelam commented Mar 13, 2023 •
edited
Loading

Verification PASSED using

Brave | 1.50.90 Chromium: 111.0.5563.64 (Official Build) beta (64-bit)
-- | --
Revision | c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS | Windows 11 Version 22H2 (Build 22621.1265)

Filed:

Pre-requisites:

  • Download Chrome Beta browser and have data for Bookmarks, History, Passwords and Extensions
  • Set France locale in Windows settings

Case 1: Set Chrome Beta as a default browser in Windows Default Apps settings

  1. Install 1.50.90
  2. launch Brave
  3. click Passer in brave://welcome page

Confirmed Google Chrome Beta is shown with check mark on brave://welcome page

Win settings Win settings step 3 France locale US locale
image image image image image

Case 2: Set Chrome Dev as a default browser in Windows Default Apps settings

  1. New profile
  2. launch Brave
  3. click Passer in brave://welcome page

Confirmed Google Chrome Dev is shown with check mark on brave://welcome page

Win settings Win settings step 3 France locale US locale
image image image image image

@MadhaviSeelam MadhaviSeelam mentioned this issue Mar 14, 2023
Closed
@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Mar 15, 2023
@stephendonner
Copy link

Spun off #29095 while testing on macOS 👍

@stephendonner stephendonner removed the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Mar 15, 2023
@stephendonner stephendonner mentioned this issue Mar 23, 2023
Closed
@stephendonner
Copy link

stephendonner commented Mar 31, 2023 •
edited
Loading

Verification PASSED using

Brave 1.50.110 Chromium: 112.0.5615.49 (Official Build) (x86_64)
Revision bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
OS macOS Version 11.7.5 (Build 20G1225)
  1. 1st attempt in Update onboarding to new design and flow #26378
  2. 2nd attempt in Follow up issue to #26378 - Default browser should be selected in Import Settings screen during onboarding process #28573
  3. 3rd attempt was in Default-browser checkmarks are missing for Chrome Dev and Chrome Beta during import #29275
  4. final solution landed in Default-browser checkmarks are missing for Chrome Beta and Chrome Dev during import #29095

The latter two are in 1.51.x and will ride the trains 🚋

As for this issue #28717, I will verify as-is for 1.50.x 👍

@btlechowski btlechowski added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Apr 3, 2023
@btlechowski
Copy link

btlechowski commented Apr 3, 2023 •
edited
Loading

Verification passed on

Brave 1.50.93 Chromium: 111.0.5563.64 (Official Build) beta (64-bit)
Revision c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS Ubuntu 18.04 LTS

Pre-requisites:

  • Download Chrome Beta browser and have data for Bookmarks, History, Passwords and Extensions
  • Set Polish locale as default

Case 1: Set Chrome Beta as a default browser

  1. Install 1.50.x
  2. launch Brave
  3. click Pomin in brave://welcome page

Confirmed Google Chrome Beta is shown with check mark on brave://welcome page

image

Pre-requisites:

  • Download Chrome Dev browser and have data for Bookmarks, History, Passwords and Extensions
  • Set Polish locale as default

Case 1: Set Chrome Dev as a default browser

  1. Install 1.50.x
  2. launch Brave
  3. click Pomin in brave://welcome page

Confirmed Google Chrome Dev is shown with check mark on brave://welcome page

image

@btlechowski btlechowski added QA Pass-Linux and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spylogsster spylogsster

Labels
feature/importer l10n OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.50.x - Release
7 participants
@stephendonner @spylogsster @bsclifton @rebron @btlechowski @brave-builds @MadhaviSeelam