Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 121.0.6167.57 to Chromium 121.0.6167.75. #35382

Closed
mkarolin opened this issue Jan 17, 2024 · 8 comments · Fixed by brave/brave-core#21600
Closed

Upgrade from Chromium 121.0.6167.57 to Chromium 121.0.6167.75. #35382

mkarolin opened this issue Jan 17, 2024 · 8 comments · Fixed by brave/brave-core#21600

Comments

@mkarolin
Copy link
Contributor

Minor Chromium bump

https://chromium.googlesource.com/chromium/src/+log/121.0.6167.57..121.0.6167.75?pretty=fuller&n=10000

QA tests:

  • Check branding items
  • Check for version bump

Additional checks:

  • No specific code changes in Brave (only line number changes in patches)
@kjozwiak
Copy link
Member

Adding QA/Blocked as the above will be uplifted into 1.62.x via brave/brave-core#21593. We'll run through the above once it lands in 1.62.x.

@kjozwiak
Copy link
Member

The above requires 1.62.148 or higher for 1.62.x verification 👍

@kjozwiak
Copy link
Member

Quick overview of the work remaining re: affected areas due to C121 on the following platforms:

Platforms that only require a spot check due to already completing full check of the affected areas mentioned via #34702 (comment):

Platforms that still need to check/verify the affected areas due to C119 changes as per #34702 (comment):

  • macOS - Still requires a pass through the affected areas
  • Linux - Still requires a pass through the affected areas

@GeetaSarvadnya
Copy link

Verification PASSED on

Brave | 1.62.149 Chromium: 121.0.6167.75 (Official Build) (64-bit)
-- | --
Revision | ff84587bd70af9fcbcbe59fc5194ca65082759c4
OS | Windows 10 Version 22H2 (Build 19045.3930)

image

@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jan 22, 2024
@LaurenWags
Copy link
Member

LaurenWags commented Jan 22, 2024

Verified cases below, to be continued with #35493 (comment).

Brave | 1.62.149 Chromium: 121.0.6167.75 (Official Build) (x86_64)
-- | --
Revision | ff84587bd70af9fcbcbe59fc5194ca65082759c4
OS | macOS Version 13.6.3 (Build 22G436)

Encountered #35495 while testing (not specific to Chromium 121).

Verifying desktop affected areas from #34702 (comment):

Tab strip looks correct (vertical and horizontal) - PASSED

Horizontal Tabs

  • Confirm that the tab strip looks good in a Card hover mode
  • Confirm that the tab strip looks good in a Card mode`
  • Confirm that the tab strip looks good in a Tooltip mode

Card hover mode

1

Card with Preview hover mode

2

Tooltip hover mode

3

Vertical Tabs

  • Confirm that the tab strip looks good in a Card hover mode
  • Confirm that the tab strip looks good in a Card mode`
  • Confirm that the tab strip looks good in a Tooltip mode

Card hover mode

1

Card with Preview hover mode

2

Tooltip hover mode

3
Check that channel name is displayed correctly in brave://version (Nightly, Beta, Release) - PASSED
  • Confirmed that channel name looks correct in nightly, beta, and release builds via brave://version/
  • Confirmed that channel name looks correct in nightly, beta, and release builds via brave://settings/help
Example Example
1 2
3 4
5 6
Tor Use Bridges setting works - PASSED
  1. Clean profile 1.62.x RC
  2. Open brave://settings/privacy
  3. Make sure Select a built-in bridge is selected and obfs4 is populated in the dropdown
  4. Click on Apply changes
  5. Ensured that the following domains opened in a Tor window without issues:
Use bridges Example Example Example Example Example
1 2 3 4 5 6
  1. Confirmed the following sites opened via "Open in Tor" button and navigated to .onion URL:
Example Example
1 2
Example Example
5 6
  1. Close the TOR window and disable Use Bridges settings and click on Apply Changes
Example Example
Screenshot 2024-01-22 at 1 34 15 PM Screenshot 2024-01-22 at 1 34 29 PM
  1. Repeat the steps 5 and 6 and ensure that the TOR network is connected successfully
Example Example Example Example Example
1 2 3 4 5
Example Example
1 2
Example Example
3 4
HTTP -> HTTPS upgrade works - PASSED
Case 1 - PASSED
Example Example Example Example
Screenshot 2024-01-22 at 2 11 57 PM Screenshot 2024-01-22 at 2 12 18 PM Screenshot 2024-01-22 at 2 12 43 PM Screenshot 2024-01-22 at 2 13 11 PM
Case 2 - PASSED

Default - Upgrade connections to HTTPS, Standard - PASSED

  1. installed 1.62.x RC build
  2. launched Brave
  3. confirmed Upgrade connections to HTTPS is set to Standard in brave://settings/shields
  4. loaded http://insecure.arthuredelstein.net
  5. loaded http://http.badssl.com
  6. loaded http://upgradable.arthuredelstein.net
  7. opened a New Private Window with Tor and loaded each of the above
default insecure.arthuredelstein.net http.badssl.com upgradable.arthuredelstein.net
Screenshot 2024-01-22 at 2 19 54 PM Screenshot 2024-01-22 at 2 21 15 PM Screenshot 2024-01-22 at 2 21 24 PM Screenshot 2024-01-22 at 2 21 32 PM

Tor

insecure.arthuredelstein.net http.badssl.com upgradable.arthuredelstein.net
Screenshot 2024-01-22 at 2 22 44 PM Screenshot 2024-01-22 at 2 22 53 PM Screenshot 2024-01-22 at 2 23 02 PM

Upgrade connections to HTTPS, Strict - PASSED

  1. installed 1.62.x RC build
  2. launched Brave
  3. changed Upgrade connections to HTTPS to Strict in brave://settings/shields
  4. loaded http://insecure.arthuredelstein.net
  5. loaded http://http.badssl.com
  6. loaded http://upgradable.arthuredelstein.net
  7. opened a New Private Window with Tor and loaded each of the above
Upgrade connections, Strict insecure.arthuredelstein.net http.badssl.com upgradable.arthuredelstein.net
Screenshot 2024-01-22 at 2 30 22 PM Screenshot 2024-01-22 at 2 30 43 PM Screenshot 2024-01-22 at 2 30 59 PM Screenshot 2024-01-22 at 2 31 19 PM

Tor

insecure.arthuredelstein.net http.badssl.com upgradable.arthuredelstein.net
Screenshot 2024-01-22 at 2 32 40 PM Screenshot 2024-01-22 at 2 32 52 PM Screenshot 2024-01-22 at 2 33 00 PM

Upgrade connections to HTTPS, Disabled - PASSED

  1. installed 1.62.x RC build
  2. launched Brave
  3. changed Upgrade connections to HTTPS to Disabled in brave://settings/shields
  4. loaded http://insecure.arthuredelstein.net
  5. loaded http://http.badssl.com
  6. loaded http://upgradable.arthuredelstein.net
  7. opened a New Private Window with Tor and loaded each of the above
Upgrade connections, Disabled insecure.arthuredelstein.net http.badssl.com upgradable.arthuredelstein.net
1 2 3 4

Tor

insecure.arthuredelstein.net http.badssl.com upgradable.arthuredelstein.net
5 6 7
Rewards, Bookmarks, VPN, Wallet buttons in the toolbar look correctly - PASSED

Default settings/enabled

  • Confirm that the Rewards, Bookmarks, VPN and Wallet settings are enabled by default via brave://settings/appearance
  • Confirmed that the Rewards, Bookmarks, VPN and Wallet buttons are shown correctly in the toolbar
  • Confirmed that click on each button works as expected
Example Example
Screenshot 2024-01-22 at 4 59 39 PM Screenshot 2024-01-22 at 4 59 48 PM

When the settings are disabled

  • Disable Rewards, Bookmarks, VPN and Wallet settings via brave://settings/appearance
  • Confirmed that the Rewards, Bookmarks, VPN and Wallet buttons are not visible in the toolbar
Example Example
Screenshot 2024-01-22 at 5 01 33 PM Screenshot 2024-01-22 at 5 01 42 PM
Tor works with a proxy set - PASSED

Tor works with Proxy

Case 1:

  1. Launch Brave with --args --enable-logging=stderr --proxy-server="socks5://localhost:9000"
  2. Visit brave.com
    ---> site doesn't load as expected due to the proxy directing traffic to localhost
  3. Visit https://brave4u7jddbv7cyviptqjc7jusxh72uik7zt6adtckl5f4nwy2v72qd.onion/
    ---> site loads since Tor doesn't use the proxy
Example Example
1 2

Case 2:

  1. Confirm Charles Proxy is set up and launched
  2. Start Brave with Charles enabled
  3. Go to brave.com in a normal window and confirm that the request is able to be seen in Charles
  4. Open a Tor window
  5. Navigate to https://brave4u7jddbv7cyviptqjc7jusxh72uik7zt6adtckl5f4nwy2v72qd.onion/
  6. Confirm the site loads as expected and is not shown in Charles
Example Example
Screenshot 2024-01-22 at 5 31 37 PM Screenshot 2024-01-22 at 5 33 26 PM

Tor works without Proxy

  1. Clean profile 1.62.x RC
  2. Ensured that the following domains opened in a Tor window without issues:
Example Example Example Example Example
Screenshot 2024-01-22 at 5 54 33 PM Screenshot 2024-01-22 at 5 54 42 PM Screenshot 2024-01-22 at 5 54 49 PM Screenshot 2024-01-22 at 5 54 58 PM Screenshot 2024-01-22 at 5 55 10 PM
  1. Confirmed the following sites opened via "Open in Tor" button and navigated to .onion URL:
Example Example
Screenshot 2024-01-22 at 5 57 16 PM Screenshot 2024-01-22 at 5 57 24 PM
Example Example
Screenshot 2024-01-22 at 5 57 31 PM Screenshot 2024-01-22 at 5 57 38 PM

@hffvld
Copy link
Contributor

hffvld commented Jan 22, 2024

Verified on Pixel 7 using version(s):

Device/OS: Pixel 7 / panther_beta-user 14 AP11.231215.007 release-keys
Brave build: 1.62.149
Chromium: 121.0.6167.75 (Official Build) (64-bit) 

1 2
1 2

@kjozwiak
Copy link
Member

kjozwiak commented Jan 22, 2024

Labelling the above as release-notes/exclude & QA/No in favour of #35493 (comment). @LaurenWags see #35493 (comment). Can remove the in-progress label whenever you're ready 👍

@hffvld
Copy link
Contributor

hffvld commented Jan 22, 2024

Verified on Galaxy Tab S8 using version(s):

Device/OS: Galaxy Tab S8 / gts8wifixx-user 13 TP1A.220624.014 release-keys
Brave build: 1.62.149
Chromium: 121.0.6167.75 (Official Build) (64-bit) 

1 2
1 2

@LaurenWags LaurenWags removed the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants