Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Move WebKit delegates into their own types owned by Tab #28061

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kylehickinson
Copy link
Collaborator

@kylehickinson kylehickinson commented Mar 10, 2025

This change removes WKNavigationDelegate, WKUIDelegate and WKDownloadDelegate conformance from BrowserViewController and creates separate handlers for those that are now owned by Tab

Resolves brave/brave-browser#44590

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@kylehickinson kylehickinson added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-teamcity Do not run builds in TeamCity labels Mar 10, 2025
@kylehickinson kylehickinson self-assigned this Mar 10, 2025
@kylehickinson kylehickinson requested a review from a team as a code owner March 10, 2025 21:44
This change removes `WKNavigationDelegate`, `WKUIDelegate` and `WKDownloadDelegate` conformance from `BrowserViewController` and creates separate handlers for those that are now owned by `Tab`
@kylehickinson kylehickinson force-pushed the ios-tab-delegate-move branch from 50459f0 to 66b028b Compare March 10, 2025 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-teamcity Do not run builds in TeamCity CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove WebKit delegate conformance from main Browser UI
1 participant