Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use getCoingeckoId Method for Meld Tokens #44609

Open
Douglashdaniel opened this issue Mar 12, 2025 · 0 comments
Open

Use getCoingeckoId Method for Meld Tokens #44609

Douglashdaniel opened this issue Mar 12, 2025 · 0 comments
Assignees
Labels
dev-concern feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes QA/No release-notes/exclude

Comments

@Douglashdaniel
Copy link

Description

Currently the list of Meld tokens that we get from the Meld API does not include a coingeckoId as a definition for a token. So when we call the getPrice api from ratios, we have to pass either the tokens symbol or contractAddress. This is causing a bunch of failures and triggering the individual price lookup fallback instead of utilizing batch requests.

To address this issue we need to map over the Meld token list and call our getCoingeckoId() method. This will give us better price information for each token and reduce the number of calls we need to make to the getPrice api.

@Douglashdaniel Douglashdaniel added dev-concern feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes QA/No release-notes/exclude labels Mar 12, 2025
@Douglashdaniel Douglashdaniel self-assigned this Mar 12, 2025
@Douglashdaniel Douglashdaniel moved this to In Progress in Web3 Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev-concern feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes QA/No release-notes/exclude
Projects
Status: In Progress
Development

No branches or pull requests

1 participant