This repository has been archived by the owner on Jan 4, 2019. It is now read-only.

C65: upgrade Node to 8.9.3 #499

Open

hferreiro opened this issue Feb 16, 2018 · 0 comments

Contributor

hferreiro commented Feb 16, 2018 •

edited

Loading

There is a WIP branch here: https://github.com/brave/muon/tree/node-upgrade/8.9.3

Currently, it is crashing in https://github.com/brave/muon/blob/node-upgrade/8.9.3/atom/common/node_bindings.cc#L191

When returning from node::CreateEnvironment(), the process_object field is somehow set to null and the call process.Set(..) crashes.

The text was updated successfully, but these errors were encountered:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.