Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmonize Thrust executable location #264

Open
francisbouvier opened this issue Feb 13, 2015 · 2 comments
Open

Harmonize Thrust executable location #264

francisbouvier opened this issue Feb 13, 2015 · 2 comments

Comments

@francisbouvier
Copy link

Hi,

Currently Thrust executable location depends on witch binding you use:

  • With python at $ENV/lib/python3.x/site-packages/pythrust/vendor/thrust/
  • With node at $ENV/node_modules/node-thrust/vendor/thrust/
  • With go at $HOME/vendor/$OS/$ARCH/$VERSION/

I think it will be good to harmonize all at $HOME/.thrust/$VERSION/

Why:

  • as a developer if you use python or node it's common to have a virtual/local environment by project. And you don't want to download and keep an executable of about 100 Mo for each project.
  • for end users it doesn't change anything as the whole app will be bundled.

What do you think ?

@miketheprogrammer
Copy link
Contributor

Thrust-Go has a SpawnProvisioner Interface. The SpawnProvisioner controls how to check/download/execute/manage a thrust executable. I may change the default to be more Harmonized however, my goal is that users are not actually using the auto download capabilities, and instead packaging the thrust exe with final installs.

@francisbouvier
Copy link
Author

@miketheprogrammer
I agree that for end users we need to provide everything (including the Thrust exe) in a bundle app.

But for developers I believe the best way is to share the Thrust exe.
For the Go binding it's already the case, but for the node and python bindings this is not (except if you sudo pip install or npm -g install but this not very common).

And it's better to have a consistent approach across all bindings of how the Thrust exe is handled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants