Refactor weather to address forecast deprecation #193
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it says on the tin. Home Assistant will be deprecating the
forecast
andattr_forecast
weather entity properties in favour of usingasync_forecast_daily
andasync_forecast_hourly
etc.I have tried to keep the change to a minimum so not to break any existing integrations but, due to the nature of the entity change, will require a design rethink on the internals. One could argue the collector is no longer required along with the sensors, as they can be derived by templates. It's a bigger discussion to be had but at the very least this integration won't languish during that time.
This addresses issue #189.