Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add binaries only for specific platform #7

Open
breuerfelix opened this issue Feb 18, 2021 · 4 comments
Open

add binaries only for specific platform #7

breuerfelix opened this issue Feb 18, 2021 · 4 comments

Comments

@breuerfelix
Copy link
Owner

No description provided.

@KotlinIsland
Copy link

KotlinIsland commented Jul 31, 2024

would this mean that we would build a wheel for each platform, each containing only the associated binary for that platform?

@breuerfelix
Copy link
Owner Author

breuerfelix commented Jul 31, 2024

@KotlinIsland yes that would reduce the pypi package size for each distro about 1/3 of the size. It would also reduce the logic in the actual package since you can always just refer to the "chromedriver" binary (except windows, that needs a .exe in the end).

@KotlinIsland
Copy link

if there are 5 binaries, wouldn't the wheel be 1/5 the size?

@breuerfelix
Copy link
Owner Author

if there are 5 binaries, wouldn't the wheel be 1/5 the size?

depends on how good the compression currently is. maybe you are right, we have to see :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants