Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading comment in defaults about max pool size #1977

Open
wraithgar opened this issue Sep 18, 2019 · 0 comments
Open

Misleading comment in defaults about max pool size #1977

wraithgar opened this issue Sep 18, 2019 · 0 comments

Comments

@wraithgar
Copy link

There is a comment in the defaults file stating that setting max to 0 disables pooling. I do not think this is true, as the underlying pg-pool lib sees that as a falsey value and defaults to 10

Here is the comment

// 0 will disable connection pooling

Here is the relevant line in pg-pool
https://github.com/brianc/node-pg-pool/blob/2d2a87392ceaf73ba0d2ed13ed9f6857e1d72ddd/index.js#L63

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant