Remove the ROM and component binaries from the disassembly

[halian]

…before Nintendō catches wind and issues a takedown notice. Please. 😟

[brianhuffman]

That's probably a good idea. I suppose I can use a checksum or a hash of the code section for regression testing instead of comparing with a known-good binary. And for building the full cartridge image, I can host the tileset binary privately instead of storing it publicly on github. Maybe I could add a script that can extract the tileset from a standard rom image that users could obtain from anywhere else.

If I want to be paranoid, it might be a good idea to rewrite the git history to remove all traces of those binaries from all the previous commits as well. What do you think?

Anway, thanks for the suggestion! It's nice to see that someone has noticed this little project :)

[halian]

Rewriting the git history would be a good idea. Most cartridge decomps that can't build ab nihilo require the user to provide their own ROM, and give checksums against which to confirm the build.

[brianhuffman]

I did some git filter-branch surgery to remove some files from the history, and force-pushed. Before closing this ticket, I'd like to take care of two additional things:

• Update the build/test script to compute and compare hashes
• Add a script to extract the tileset from a full rom image