Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Build Errors from Outdated Dependency #42

Closed

Conversation

CriticalFloof
Copy link
Contributor

ttypescript v1.5.13 caused a build error to occur when node version was v18.17.1 or more.
Updating ttypescript to v1.5.15 seems to resolve this issue.

ttypescript v1.5.13 caused a build error to occur when node version was v18.17.1 or more.
Updating ttypescript to v1.5.15 seems to resolve this issue.
@CriticalFloof
Copy link
Contributor Author

I put some commits yesterday on this PR that also changed the version and did "audit fix". I was trying to be helpful and was looking at how Meshiest did updates, but I realized that updating the version in a PR itself is probably not the best approach.
So, I reverted those commits.
Best to leave it to the maintainers, lesson learned lol.

@voximity
Copy link
Member

voximity commented Dec 3, 2023

This looks good, but I have a suggestion if you're interested.

It looks like ttypescript is now deprecated and will not work for versions of TS >=5. Its README says it has been replaced by ts-patch, which seems to function more or less the same.

If you'd like, you could replace our usage of ttypescript with ts-patch. From what I can tell, you would only have to remove the dependency on ttypescript and add ts-patch, then replace instances of ttsc with tpsc in our build scripts (like in package.json).

This gives us some future breathing room for when we decide to bump TypeScript and lets us rely on one fewer deprecated package :)

@CriticalFloof
Copy link
Contributor Author

I took a look at swapping the dependency; however, I receive a compile error stating the package needs typescript v5 or greater. Upgrading typescript causes more compilation errors. I'll continue to look for a solution to make it work, I'm open to ideas.

@CriticalFloof
Copy link
Contributor Author

This PR should be irrelevant now, so I'm going to close it. Have a look at this more fitting PR:
Replace ttypescript with tsc-alias

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants