-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(terraform): support resource_type attribute #6872
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ewio/checkov into fix/steve/resource_type
SteveVaknin
requested a deployment
to
scan-security
November 25, 2024 08:34 — with
GitHub Actions
Waiting
SteveVaknin
requested a deployment
to
scan-security
November 25, 2024 08:34 — with
GitHub Actions
Waiting
SteveVaknin
changed the title
Fix/steve/resource type
feat(terraform): support resource_type attribute
Nov 25, 2024
SteveVaknin
requested a deployment
to
scan-security
November 25, 2024 15:15 — with
GitHub Actions
Waiting
SteveVaknin
temporarily deployed
to
scan-security
November 26, 2024 09:01 — with
GitHub Actions
Inactive
omriyoffe-panw
approved these changes
Nov 26, 2024
ChanochShayner
approved these changes
Nov 26, 2024
Saarett
pushed a commit
that referenced
this pull request
Nov 26, 2024
* feature(terraform): support resource_type attribute * fix lint issues * add missing type * move to func * move comment * fix lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
resource_type
attribute in terraform graph scanning.For example:
Fixes # (issue)
New/Edited policies (Delete if not relevant)
Description
Include a description of what makes it a violation and any relevant external links.
Fix
How does someone fix the issue in code and/or in runtime?
Checklist:
Generated description
Below is a concise technical summary of the changes proposed in this PR:
Introduce support for the
resource_type
attribute in Terraform graph scanning by modifying theBaseAttributeSolver
andModule
classes. TheBaseAttributeSolver
now wraps reserved attributes to ensure they are scanned correctly. TheModule
class alters reserved attributes to includeresource_type
in the scanning process. Additionally, a new test case intest_module.py
verifies the correct handling of theresource_type
attribute.resource_type
attribute in Terraform modules.Modified files (1)
Latest Contributors(2)
resource_type
attribute in Terraform graph scanning.Modified files (3)
Latest Contributors(2)