-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This plugin stopped working because of changes made by maxmind #4
Comments
Download URL should be updated to https://download.maxmind.com/app/geoip_download?edition_id=GeoLite2-Country&license_key=[LICENSE_KEY]&suffix=tar.gz and there should be way to provide end user license key - I believe Composer has section '''extra''' in composer.json for this. Users have to create maxmind account and generate their license key. |
I think we'd need to go with an environment variable instead of the Otherwise, that would lead to trouble where people publically commit their keys and other people reuse them. |
@schlessera are there any plans on updating this module according to the new download method? Thanks in advance |
I added a PR (see #5) which updates the module to work with the new method by MaxMind. I implemented using the root composer.json as this seemed to work for me (knowing the downsides of course) but it should be fairly easy to add other ways of passing the license by (for example) environment variables. |
https://blog.maxmind.com/2019/12/18/significant-changes-to-accessing-and-using-geolite2-databases/
The text was updated successfully, but these errors were encountered: