Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests: Remove mountLog from global test state #60

Open
wokalski opened this issue Nov 20, 2019 · 0 comments
Open

Tests: Remove mountLog from global test state #60

wokalski opened this issue Nov 20, 2019 · 0 comments

Comments

@wokalski
Copy link
Member

We could instead move mountLog to TestHelpers.re and pass a ref to mountLog in root when insertNode or moveNode is called. It'll remove the need for resetting the state in tests which is error prone.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wokalski