Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subfactions #34

Open
morteeke opened this issue Dec 19, 2023 · 2 comments
Open

Subfactions #34

morteeke opened this issue Dec 19, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@morteeke
Copy link

morteeke commented Dec 19, 2023

Hello @brittonhayes!

Would it be possible to add a variable for the allegiance objects to have their subfactions?
I am not sure if it already is implemented, if so where can I find it? :D

I have a few more things I would like to ask of you. Could you also add, just like the 'champion' variable, a 'standard bearer', 'musician' and 'mount' variable?

While I am at it, could you also add a variable that describes a unit's lore?

Thanks for making my life a little bit easier!

PS: you might already have mentioned this, but can I just add these variables myself and then fork it? or do you have to implement them? My guess would go to the latter.

@morteeke morteeke added the enhancement New feature or request label Dec 19, 2023
@brittonhayes
Copy link
Owner

@morteeke Okay so for this list, let's break this down into a few items and you let me know if I've heard you correctly 😃

For adding new properties to objects (e.g. mount or lore), yeah you're correct. I'll need to add those because we're modifying properties in our schemas (e.g. cities, units etc). For adding content to the database for existing schemas, you can totally just make a fork and add your new content then open a pull request.

It's just when we're changing the shape of the data, ya can just let me do it for simplicity. You're of course welcome to, but it is more involved 😄

As for the list of changes requested, let me know if I got everything here:

Changes

  • Allegiance Changes
    • Add property: subfaction (string)
  • Unit Changes
    • Add property: standard_bearer (string)
    • Add property: musician (string)
    • Add property: mount (string)
    • Add property: lore (string)

@morteeke
Copy link
Author

@brittonhayes that list you made is exactly what I would like!

I know I have been waiting a long time to make some forks, but it will happen haha. Were you busy with some allegiance? I was planning on doing the stormcast eternals and the slaves to darkness, as those are the armies I use to play the game. Just want to know so that we won't be overlapping eachother.

Friends of mine are using Orruks, Behemath, Ogurs, Sylvanth and Slaanesh. So I can let them add some units aswell.

Hope you had a wonderfull christmass and best wishes for the new year! 🥂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants