Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

Icon selection #100

Open
NoNamePaul opened this issue Jun 5, 2018 · 3 comments
Open

Icon selection #100

NoNamePaul opened this issue Jun 5, 2018 · 3 comments

Comments

@NoNamePaul
Copy link

I have 2 little issues with the icon selection screen:

  1. The searchbar sometimes doesn't appear. I have to click custom icon and cancel to make it reappear (Probably gone with the new UI together with the X button being invisible)
  2. The search function appears to not function correctly at all:
    I tried search for the Cyclone Icon (Druid) in 3 different ways:
    • Typing "cyclone"
    • Typing the icon ID (136022 from wowhead)
    • Typing the icon's name "Spell_nature_earthbind" (from wowhead)
      None of these found the icon, just random other stuff or nothing at all.

It's really frustrating to go through all the icons to make the perfect interface.

@brittyazel
Copy link
Owner

Yeah I agree 100% that the search bar is broken. I thought I had the search bar hidden, but I guess you figured out how to get it to come back ;-)

The reason that the search is broken is because we can't search for icons based on Strings anymore, i.e. "cyclone". As of Legion, the only way to query an icon is to know the exact path location or the texture id, i.e. 445050504. Hence, since we're using the texture id's to populate the list we have lost our ability to have any "searchable". This was one of the very first bugs I encountered after taking over the project, so maybe I'll give it another go now that I'm more seasoned.

@NoNamePaul
Copy link
Author

Maybe you could just give us an input field for an ID? We can easily search for it on wowhead:
So cyclone would be 136022?
Or is the texture id not the one shown in the wowhead url?

@brittyazel
Copy link
Owner

Hah, wouldn't that be nice. Nope what you listed is the SpellID, which is different from the texture ID. Fun right?!

I'm sure there's an elegant way to address this, I just have to be really clever, which only happens every once and a while lol

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants