Skip to content
This repository has been archived by the owner on Jan 21, 2024. It is now read-only.

Having Blizzard Actionbars hidden in settings prevents ExtraActionButton from showing #477

Open
Ketrel opened this issue Nov 28, 2022 · 4 comments
Assignees
Labels

Comments

@Ketrel
Copy link

Ketrel commented Nov 28, 2022

How to reproduce / Issue description:**

  1. Ensure that in the "Display the Blizzard UI" settings ActionBar is unchecked and Extra Action Bar is checked

Results: Extra Action Button is NOT displayed
Expected Results: Extra Action Button is displayed

Technical info:

  • Addon Version: commit 6d8a8c3
  • Client: Retail
  • Client Patch Version: 10.0.2

Additional context:

I've traced it to line 87 in Neuron-DisableBlizzardUI.lua which runs when Blizzard ActionBars are set to be hidden

ActionBarController:UnregisterAllEvents()  

The comment says that's to avoid potential for taints, but it unfortunately looks like it also prevents whatever event would show the blizzard extra action button.

@ylixir
Copy link
Collaborator

ylixir commented Nov 28, 2022

i haven't figured out a good place to test the extra action button (or the zone buttons)

this isn't happening at a place that would be easy for me to test is it?

@brittyazel
Copy link
Owner

brittyazel commented Nov 28, 2022

Suramar City will activate both the Extra Button and the zone ability button

@Ketrel
Copy link
Author

Ketrel commented Nov 28, 2022

I used Suramar for my testing to isolate the line causing the issue.

For zone, Draenor Garrison works as that's just zone, not extra.

@ylixir
Copy link
Collaborator

ylixir commented Dec 3, 2022

add vehicle exit button to this list as well

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants