From 7c7177f70b6349259bd8d0aa36cc623ba86c4a2d Mon Sep 17 00:00:00 2001 From: Hana Snow Date: Wed, 2 Aug 2023 11:01:18 -0400 Subject: [PATCH] handle empty fre filters --- hail_search/hail_search_query.py | 2 +- hail_search/test_search.py | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/hail_search/hail_search_query.py b/hail_search/hail_search_query.py index fe592e09f6..611b54a6ad 100644 --- a/hail_search/hail_search_query.py +++ b/hail_search/hail_search_query.py @@ -349,7 +349,7 @@ def _filter_by_frequency(self, frequencies): if hemi_field: pop_filters.append(pop_expr[hemi_field] <= freqs['hh']) - if pop_filters is not None: + if pop_filters: pop_filter = pop_filters[0] for pf in pop_filters[1:]: pop_filter &= pf diff --git a/hail_search/test_search.py b/hail_search/test_search.py index 75b7f6f2e3..9e0aba5dc9 100644 --- a/hail_search/test_search.py +++ b/hail_search/test_search.py @@ -181,6 +181,11 @@ async def test_frequency_filter(self): omit_sample_type='SV_WES', ) + await self._assert_expected_search( + [VARIANT1, VARIANT2, MULTI_FAMILY_VARIANT, VARIANT4], frequencies={'seqr': {}, 'gnomad_genomes': {'af': None}}, + omit_sample_type='SV_WES', + ) + async def test_search_missing_data(self): search_body = get_hail_search_body(sample_data=FAMILY_2_MISSING_SAMPLE_DATA) async with self.client.request('POST', '/search', json=search_body) as resp: