Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: test "failures" has a misleading definition #400

Open
Stephen986 opened this issue Oct 26, 2023 · 1 comment
Open

[Bug]: test "failures" has a misleading definition #400

Stephen986 opened this issue Oct 26, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@Stephen986
Copy link

Overview

The definition of "failures" is misleading: https://github.com/brooklyn-data/dbt_artifacts/blob/main/models/docs.md?plain=1#L184. It makes it sound like a field that is either 1 or 0, but failures can be much higher than 0 if multiple records fail the test.

How to reproduce

  1. Read the docs on "failures"
  2. Query your dbt artifacts data:
  3. SELECT * FROM dbt-artifacts.mart__dbt_artifacts.fct_dbt__test_executions
    where failures > 1 LIMIT 10;

Expected behaviour

The docs should indicate that failures can be greater than 0. I'm not sure the best possible description, but maybe something like: "A single test execution can have multiple failures if multiple rows had incorrect results."

Environment

Results of running dbt --version:

1.6
@Stephen986 Stephen986 added the bug Something isn't working label Oct 26, 2023
@jared-rimmer
Copy link
Member

@Stephen986 happy to accept a PR with a definition you propose

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants