Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update testing structure for dbt Labs testing support - postgres #451

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

emmyoop
Copy link

@emmyoop emmyoop commented Oct 11, 2024

Overview

Resolves #443

This PR make a slight update to the current testing layout to allow dbt Labs to start testing this package as part of our own
release process.

This only adds support for testing with postgres. Postgres is run inside the GitHub runner and I do not need to worry about getting credentials for the various warehouses set up this way.

To add additional adapter testing support in the future, you will just need to modify

  • .github/workflows/ci_dbt_test_package.yml to pass through the env vars
  • modify profiles.yml to meet the desire var format (example in dbt-package-testing)
  • supported_adapters.env to list the adapters you want to test
  • tox.ini to add the commands for the associated adapter tests

I've left your current testing as is to allow you to decide what to do with it.

Why Do We Need These Changes

As explained in #443 , by setting up tox as a standard entry-point, the Core development team at dbt Labs can include this package's integration tests (along with other popular dbt packages) as part of our continuous development & delivery of dbt.

Update type - breaking / non-breaking

  • Minor bug fix
  • Documentation improvements
  • Quality of Life improvements
  • New features (non-breaking change)
  • New features (breaking change)
  • Other (non-breaking change)
  • Other (breaking change)
  • Release preparation

What does this solve?

Outstanding questions

What databases have you tested with?

  • Snowflake
  • Google BigQuery
  • Databricks
  • Spark
  • N/A

@emmyoop emmyoop had a problem deploying to Approve Integration Tests October 11, 2024 14:30 — with GitHub Actions Failure
@emmyoop emmyoop had a problem deploying to Approve Integration Tests October 11, 2024 14:30 — with GitHub Actions Failure
@emmyoop emmyoop had a problem deploying to Approve Integration Tests October 11, 2024 14:30 — with GitHub Actions Failure
@emmyoop emmyoop had a problem deploying to Approve Integration Tests October 11, 2024 14:30 — with GitHub Actions Failure
@emmyoop emmyoop had a problem deploying to Approve Integration Tests October 11, 2024 14:39 — with GitHub Actions Failure
@emmyoop emmyoop had a problem deploying to Approve Integration Tests October 11, 2024 14:39 — with GitHub Actions Failure
@emmyoop emmyoop had a problem deploying to Approve Integration Tests October 11, 2024 14:39 — with GitHub Actions Failure
@emmyoop emmyoop had a problem deploying to Approve Integration Tests October 11, 2024 14:39 — with GitHub Actions Failure
@emmyoop emmyoop changed the title modify test infra to meet expected dbt format Update testing structure for dbt Labs testing support Oct 11, 2024
@emmyoop emmyoop changed the title Update testing structure for dbt Labs testing support Update testing structure for dbt Labs testing support - postgres Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tox-based Integration Testing support for this package
1 participant