Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maybe we should add ability to call bg-functions from bg-inject as well? #54

Open
Manvel opened this issue Sep 5, 2020 · 3 comments
Open

Maybe we should add ability to call bg-functions from bg-inject as well? #54

Manvel opened this issue Sep 5, 2020 · 3 comments
Labels
question Further information is requested

Comments

@Manvel
Copy link
Member

Manvel commented Sep 5, 2020 •
edited
Loading

cbaFn.removecookies();?
@Manvel Manvel changed the title Maybe we should remove bg-functions? Maybe we should add ability to call bg-functions from bg-inject as well? Sep 5, 2020
@Manvel
Copy link
Member Author

Manvel commented Sep 5, 2020 •
edited
Loading

Note we want to keep bg-functions, as we may use it with custom inputs. Thought technically it doesn't matter how we generate those, so the bg-inject can work as well.

@Manvel
Copy link
Member Author

Manvel commented Sep 12, 2020 •
edited
Loading

If bg-inject is used, warning might be shown on play btn hover.

@Manvel
Copy link
Member Author

Manvel commented Sep 12, 2020

What about introducing inputs for bg-function:

  • input1 - function name
  • input2 - attr1
  • input3 - attr2
    ...

@Manvel Manvel added the question Further information is requested label Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Manvel