Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamically adjust chunk size #300

Open
seanmcguire12 opened this issue Dec 13, 2024 · 0 comments
Open

Dynamically adjust chunk size #300

seanmcguire12 opened this issue Dec 13, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@seanmcguire12
Copy link
Collaborator

The motivation for this issue is described in #236, which implemented a temporary fix. We need to implement a more reliable fix for this issue instead of having a set value of 75% of the viewport height. If a sticky banner happens to take up more than 25% of the viewport, then we are still going to be missing candidate elements. Also, if there is no sticky banner, or a very small one, then we are going to be chunking unnecessarily slowly.

Therefore, we need to come up with a solution to dynamically detect sticky/fixed banners on the fly, and then adjust the viewport height accordingly.

@seanmcguire12 seanmcguire12 added the enhancement New feature or request label Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant