Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi-week event bug #85

Closed
bruceharrison1984 opened this issue Mar 20, 2023 · 2 comments · Fixed by #91
Closed

Multi-week event bug #85

bruceharrison1984 opened this issue Mar 20, 2023 · 2 comments · Fixed by #91
Labels
bug Something isn't working

Comments

@bruceharrison1984
Copy link
Owner

Describe the bug
Multi-week event is not rendering correctly

image

To Reproduce
Not sure exactly what conditions are causing this, but it is rare.

Expected behavior
The event should span the proper weeks
@bruceharrison1984 bruceharrison1984 added the bug Something isn't working label Mar 20, 2023
@bruceharrison1984
Copy link
Owner Author

bruceharrison1984 commented Apr 14, 2023 •
edited
Loading

This bug seems to only appear for certain multi-week events, when the component first loads. Navigating to another month and returning back corrects the display issue. Refreshing the page causes the issue to appear again.

@bruceharrison1984
Copy link
Owner Author

This bug seems to have stemmed from the isDateBetween method mutating the underlying dates that it dealt with. Cloning these dates to prevent mutation seems to have fixed the issue.

This is in addition to a much faster method of verifying the start/end days of events.

@bruceharrison1984 bruceharrison1984 linked a pull request Jul 7, 2023 that will close this issue
Custom start of week #91
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Custom start of week bruceharrison1984/Schedulely
1 participant
@bruceharrison1984