Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PluginManager doesn't take into account the minVersion tag #122

Open
dinkumoil opened this issue Jul 29, 2018 · 0 comments
Open

PluginManager doesn't take into account the minVersion tag #122

dinkumoil opened this issue Jul 29, 2018 · 0 comments

Comments

@dinkumoil
Copy link

dinkumoil commented Jul 29, 2018

Description of the Issue

32 bit PluginManager's admin system at https://npppm.bruderste.in provides the ability to define a minimal Notepad++ version for a plugin. In the resulting XML file this produces a minVersion tag. PluginManager neither taks into account this tag when it shows the list of available plugins nor does it when user chooses to install a plugin.

Steps to Reproduce the Issue

  1. Download a ZIP version of Notepad++ v7.5.6 (32 or 64 bit) and unzip the file.
  2. Download and install appropriate (32 or 64 bit) latest version of PluginManger (currently v1.4.11).
  3. Start Notepad++ and open PluginManger.
  4. Switch to Available tab.
  5. Check entry of AutoCodepage plugin (v1.2.2) and click on Install button.

Expected Behavior

Since the AutoCodepage plugin is tagged with <minVersion>7.5.7</minVersion> either it should not been displayed in plugin list under Notepad++ v7.5.6 or PluginManager should display a message that the plugin isn't suitable for this version of Notepad++ and thus installation should be refused.

Actual Behavior

AutoCodepage plugin is displayed in PluginManager's plugin list and can be installed without any problem or warning though the version of Notepad++ (v7.5.6) doesn't fit the minVersion requirements.

Debug Information

ZIP installation of Notepad++ v7.5.6, 32 bit and 64 bit
PluginManager v1.4.11, 32 bit or 64 bit
AutoCodepage plugin v1.2.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant