Run when Notepad++ is closed option is not working properly

[jcaillon]

Hello,

Description of the Issue

In the web interface for x32 plugins you can add a step run to run a program and you have an option called Run when Notepad++ is closed.

Whether you check this option or not, the program is run after copying the .dll file and before the plugin manager displays the following message : Press OK when the installation program has completed.

Once you press ok you have the message to restart : Notepad++ needs to be restarted for changes to take effect. Would you like to do this now?

Content of plugins\Config\PluginManagerPlugins.xml when reproducing this issue :

<?xml version="1.0" encoding="UTF-8"?>
<plugins>
   <plugin name="3P - Progress Programmers Pal">
      <unicodeVersion>1.8.1</unicodeVersion>
      <aliases>
         <alias name="3P" />
      </aliases>
      <description>[Requires .net framework 4.6.2]\n\n3P is a notepad++ plug-in designed to help writing OpenEdge ABL (formerly known as Progress 4GL) code. It provides :\n\n- a powerful auto-completion\n- tool-tips on every words\n- a code explorer to quickly navigate through your code\n- a file explorer to easily access all your sources\n- the ability to run/compile and even PROLINT your source file with an in-line visualization of errors\n- more than 50 options to better suit your needs\n- and so much more!\n\nVisit http://jcaillon.github.io/3P/ for more details on the plugin</description>
      <author>Julien Caillon</author>
      <homepage>http://jcaillon.github.io/3P/</homepage>
      <sourceUrl>https://github.com/jcaillon/3P</sourceUrl>
      <latestUpdate>More infos here :\nhttps://github.com/jcaillon/3P/releases/tag/v1.8.1</latestUpdate>
      <stability>Good</stability>
      <install>
         <unicode>
            <download>https://github.com/jcaillon/3P/releases/download/v1.8.1/3P.zip</download>
            <copy from="3P.dll" to="$PLUGINDIR$\" validate="true" />
            <run file="NetFrameworkChecker.exe" arguments="" outsideNpp="1" />
         </unicode>
      </install>
      <remove>
         <unicode>
            <delete file="$PLUGINDIR$\3P.dll" />
         </unicode>
      </remove>
   </plugin>
</plugins>

Expected Behavior

If the option Run when Notepad++ is closed is checked, I expect the program to run when notepad++ is closed

Actual Behavior

It is run before the plugin manager asks the user to restart notepad++

More Information

Notepad++ v7.5.5 (32-bit)
Build time : Feb 27 2018 - 21:44:21
Path : C:\Work\3P_notepad++_stable\notepad++.exe
Admin mode : OFF
Local Conf mode : ON
OS : Windows 10 (64-bit)
Plugins : DSpellCheck.dll mimeTools.dll NppConverter.dll NppExport.dll PluginManager.dll

plugin manager v1.4.10.0

This bug is related to this issue :
#96 : Plugins list x32 - web interface - bug when unchecking `Run when Notepad++ is closed

Please don't fix this one before enabling us to uncheck this option in the web interface :)

Best regards.

[chcg]

See:
https://github.com/bruderstein/nppPluginManager/blob/master/libinstall/src/InstallStepFactory.cpp#L111-115

plugin code is checkin for true, but webinterface/server is producing outsideNpp="1"

[chcg]

@bruderstein Could this be resolved on server side? Or should I add a workaround with checking also for "1"?

[jcaillon]

The problem with the workaround is that plugin developers will have no way of setting this to FALSE/0 and the few plugins using this feature all want (or at least, currently use by force) FALSE.

regards

[chcg]

@jcaillon ok, so I will leave it as is, as long as no change on server side is done, also for x64 where the input is manually created the expected behaviour could be achieved.