Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corkscrew install from brew has broken Proxy-Authorization #12

Open
louisbuchbinder opened this issue Oct 5, 2020 · 4 comments
Open

Comments

@louisbuchbinder
Copy link

louisbuchbinder commented Oct 5, 2020

Steps to reproduce:

  • Install corkscrew using brew brew install corkscrew
  • Create auth file echo user@pass > auth
  • Make corkscrew request: corkscrew localhost 8000 localhost 8001 auth
  • Header come through like: Proxy-Authorization: Basic Q09OTkVDVCBsb2NhbGhvc3Q6ODAwMSBIVFRQLzEuMApQcm94eS1BdXRob3JpemF0aW9uOiBCYXNpYyA=
  • Decoding the auth header:
base64 --decode <<< 'Q09OTkVDVCBsb2NhbGhvc3Q6ODAwMSBIVFRQLzEuMApQcm94eS1BdXRob3JpemF0aW9uOiBCYXNpYyA='
CONNECT localhost:8001 HTTP/1.0
Proxy-Authorization: Basic 

Notes

  • It seems like the request headers themselves are being base64 encoded instead of the contents of the auth file.
  • I built corkscrew from source and the auth works as expected. Possibly this is as simple as publishing the latest corkscrew to homebrew.
corkscrew --version
corkscrew 2.0 ([email protected])

Thank you this is very useful software for me.

@louisbuchbinder
Copy link
Author

Just created a pull request with updates to the readme for building on macOS. Just a couple pre-install steps and building from source works like a charm.

@louisbuchbinder
Copy link
Author

pr is here: #11

@ChrisHardie
Copy link

Confirming that on macOS 14.2.1 with Homebrew 4.2.5, the brew-installed version of corkscrew did not handle proxy authentication (proxy server essentially saw no auth attempt), but when built from source it worked fine.

@pserrano
Copy link

Same here, Apple m3 and m1 with macOS 14.6.1 with Homebrew 4.3.17, the brew-installed version of corkscrew did not handle proxy authentication (proxy server give error auth), but when built from source it worked fine as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants