From b2f940d8c7c3e71ce7baeab5cfdb38e28efff869 Mon Sep 17 00:00:00 2001 From: Bryce Anderson Date: Fri, 3 Jan 2025 19:49:18 -0700 Subject: [PATCH] Another better code comment --- .../servicetalk/http/netty/RetryingHttpRequesterFilter.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/servicetalk-http-netty/src/main/java/io/servicetalk/http/netty/RetryingHttpRequesterFilter.java b/servicetalk-http-netty/src/main/java/io/servicetalk/http/netty/RetryingHttpRequesterFilter.java index b245495137..98a614d699 100644 --- a/servicetalk-http-netty/src/main/java/io/servicetalk/http/netty/RetryingHttpRequesterFilter.java +++ b/servicetalk-http-netty/src/main/java/io/servicetalk/http/netty/RetryingHttpRequesterFilter.java @@ -237,9 +237,9 @@ Completable applyRetryCallbacks(final Completable completable, final int retryCo if (returnOriginalResponses) { final StreamingHttpResponse response = extractStreamingResponse(t); if (response != null) { - // If we succeed, we need to drain the response body before we continue. If we fail we want to - // surface the original exception and don't worry about draining since it will be returned to - // the user. + // If we succeed, we need to drain the response body before we continue. The retry completable + // fails we want to surface the original exception and don't worry about draining since the + // response will be returned to the user. result = result.onErrorMap(backoffError -> ThrowableUtils.addSuppressed(t, backoffError)) // If we get cancelled we also need to drain the message body as there is no guarantee // we'll ever receive a completion event, error or success. This is okay to do since