Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider accepting three-dimensional edge Tensors for MatrixProductState #47

Closed
jofrevalles opened this issue Apr 6, 2023 · 1 comment
Closed

Consider accepting three-dimensional edge Tensors for MatrixProductState #47

jofrevalles opened this issue Apr 6, 2023 · 1 comment
Labels
question Further information is requested

Comments

@jofrevalles
Copy link
Member

We could loose the current requirements that disallow creating a MatrixProductState where all the tensors are three-dimensional. In that case, we could just check that the dimension of the left and right index for the first and last Tensor, respectively, are one.

I think this could allow an easier implementation of the algorithms where MatrixProductState are used since it is easier to generalize the code, and we wouldn't have to worry about the boundary Tensors being different.
What do you think?
@jofrevalles jofrevalles added the question Further information is requested label Apr 6, 2023
@mofeing
Copy link
Member

mofeing commented Nov 3, 2023

Related code moved to Qrochet.jl.

@mofeing mofeing closed this as not planned Won't fix, can't repro, duplicate, stale Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mofeing @jofrevalles