Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accounts may not be displayed in order of account number. #23

Open
jrick opened this issue Feb 14, 2016 · 0 comments
Open

Accounts may not be displayed in order of account number. #23

jrick opened this issue Feb 14, 2016 · 0 comments

Comments

@jrick
Copy link
Member

jrick commented Feb 14, 2016

The Wallet model class uses a Dictionary keyed by Account (numbers) to store account properties. When used as an IEnumerable, the order is not defined. This can cause the ObservableCollection of recent accounts in the shell view model (which does have an ordering) to order the accounts in an implementation dependent manner.

I think the best way to solve this issue is to maintain a sorted List of accounts and their properties in the Wallet class. Other than the imported account (which is planned to be removed from btcwallet in a later update), all accounts numbers are strictly increasing.

jrick added a commit to jrick/Paymetheus that referenced this issue Apr 12, 2016
When enumerated, accounts are now returned in increasing order by
their account number.

Fixes btcsuite#23.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant