Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating transactions should not allow creating dust. #45

Open
jrick opened this issue Feb 24, 2016 · 1 comment
Open

Creating transactions should not allow creating dust. #45

jrick opened this issue Feb 24, 2016 · 1 comment

Comments

@jrick
Copy link
Member

jrick commented Feb 24, 2016

At the moment, dust outputs are not checked for when constructing a new transaction. At the very least, the send should fail. A nicer implementation would show an error next to each dust output and prevent the transaction from ever being constructed.

Once #43 is done, the user could set a higher transaction fee, which could change the dust threshold. This is less surprising than modifying any fee estimation logic to use a higher relay fee just to accommodate a dust output.

@jrick
Copy link
Member Author

jrick commented Feb 26, 2016

My comment about using this fee to change the dust threshold is incorrect. The dust limit determined by a full node is not based on the transaction's actual fee/kB but the minimum relay fee used for the mempool's acceptance policy.

The only thing we can do here is display a nice error next to dust outputs, and perhaps inform the user what the dust limit actually is so they can fix it by sending a larger output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant