Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

btcjson: duplicate error codes #2066

Open
yyforyongyu opened this issue Nov 29, 2023 · 2 comments
Open

btcjson: duplicate error codes #2066

yyforyongyu opened this issue Nov 29, 2023 · 2 comments

Comments

@yyforyongyu
Copy link
Collaborator

There are a few places that the same RPC error code are used,

btcd/btcjson/jsonrpcerr.go

Line 63 in 6ea604d

ErrRPCVerify RPCErrorCode = -25

btcd/btcjson/jsonrpcerr.go

Line 180 in 6ea604d

ErrRPCTxError RPCErrorCode = -25

We should make sure they are not duplicated.
@yemmyharry
Copy link

hi @yyforyongyu I would love to contribute to this. kindly provide more details

@yyforyongyu
Copy link
Collaborator Author

@yemmyharry an easy fix would be using a new code and test them out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yyforyongyu @yemmyharry