Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change between btcec/v2 minor versions v2.3.2 and v2.3.4 #2243

Open
joshklop opened this issue Aug 28, 2024 · 3 comments
Open

Breaking change between btcec/v2 minor versions v2.3.2 and v2.3.4 #2243

joshklop opened this issue Aug 28, 2024 · 3 comments

Comments

@joshklop
Copy link

SignCompact's return type changed from ([]byte, error) to []byte.

Before:

func SignCompact(key *btcec.PrivateKey, hash []byte,
isCompressedKey bool) ([]byte, error) {

After:

func SignCompact(key *btcec.PrivateKey, hash []byte,
isCompressedKey bool) []byte {

Would it be possible to retract the v2.3.4 version (and possibly v2.3.3) in the go.mod file?

cc @NiloCK

@Roasbeef
Copy link
Member

See #2221

@joshklop
Copy link
Author

Thanks @Roasbeef. If retracting the version has already been decided against, this issue can be closed. Otherwise, it may be beneficial to consider.

@Chan7348
Copy link

Why do you change the interface in small version update????????????????

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants